make ngrok an optional dependency #39
Conversation
had to use peerDependencies in package.json as optionalDependencies are still installed by default and ngrok fails without --unsafe-perm=true even if in an optionalDependencies
| ``` | ||
|
|
||
| The dependency `ngrok` requires full write permission in `/usr/local/lib/node_modules` during its custom install phase. This is a [known ngrok issue](https://github.com/inconshreveable/ngrok/issues/429). | ||
| The dependency `ngrok` requires full write permission in `/usr/local/lib/node_modules` during its custom install phase. This is a [known ngrok issue](https://github.com/bubenshchykov/ngrok/issues/87). |
There was a problem hiding this comment.
Wondering if the sudo npm install... command just above this block should be changed to just installing ngrok instead of openwhisk/debug?
There was a problem hiding this comment.
This is not the normal install command. This is the troubleshooting section which I kept in for folks still having an older version...
This PR was all about making the normal command easier from the very unusual
npm install -g @openwhisk/wskdebug --unsafe-perm=true
to the usual
npm install -g @openwhisk/wskdebug
There was a problem hiding this comment.
right. guess it makes sense to leave comment in for a little while (or until the next release). without the history, it just reads a little oddly since it is telling people about problems with an install mode that isn't mentioned anywhere else in the doc
There was a problem hiding this comment.
Yes, will remove after the next release.
to prevent confusion with real 1.2.0 if using the master branch
3 participants
Fixes #22.
Also print better error message if no openwhisk credentials are found/specified.
No unit test yet. Might add one tomorrow using a docker container doing "fresh" npm installs...