Skip to content

make ngrok an optional dependency #22

@alexkli

Description

@alexkli

ngrok installation requires --unsafe-perm=true in the install script, which is unusual and should be avoided for the main installation instructions.

It is already an optional feature only triggered by --ngrok, so it is probably better to make it an optional npm dependency and ask people to install it separately using npm install -g ngrok --unsafe-perm=true if needed.

  • move ngrok to optionalDependencies
  • load only if needed (--ngrok argument specified ) as illustrated here
  • if not installed, give error message explaining how to install it

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions