Skip to content

Conversation

@mrutkows
Copy link
Contributor

@mrutkows mrutkows commented Feb 10, 2021

Update to Go 1.15, remove deprecated godeps/vendor in favor of go.mod (go mod).

@mrutkows mrutkows marked this pull request as ready for review February 15, 2021 22:48
@mrutkows mrutkows marked this pull request as draft February 15, 2021 22:48
@mrutkows mrutkows marked this pull request as ready for review February 23, 2021 16:44
@mrutkows
Copy link
Contributor Author

@rabbah @jiangpengcheng Please review if able, thanks!

README.md Outdated

### GoLang setup

The wskdeploy utility is a GoLang program so you will first need to [Download and install GoLang](https://golang.org/dl/) onto your local machine.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this mentioned here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove (cut and pasted too much)

README.md Outdated

As the code is managed using GitHub, it is easiest to retrieve the code using the `git clone` command.

if you just want to build the code and do not intend to be a Contributor, you can clone the latest code from the Apache repository:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if you just want to build the code and do not intend to be a Contributor, you can clone the latest code from the Apache repository:
If you just want to build the code and do not intend to be a Contributor, you can clone the latest code from the Apache repository:

README.md Outdated
git clone [email protected]:apache/openwhisk-client-go
```

or you can specify a release (tag) if you do not want the latest code by using the `--branch <tag>` flag. For example, you can clone the source code for the tagged 1.1.0 [release](https://github.com/apache/openwhisk-client-go/releases)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
or you can specify a release (tag) if you do not want the latest code by using the `--branch <tag>` flag. For example, you can clone the source code for the tagged 1.1.0 [release](https://github.com/apache/openwhisk-client-go/releases)
You can also specify a release (tag) if you do not want the latest code by using the `--branch <tag>` flag. For example, you can clone the source code for the tagged 1.1.0 [release](https://github.com/apache/openwhisk-client-go/releases)

@mrutkows mrutkows merged commit 9c1b901 into apache:master Feb 23, 2021
@mrutkows mrutkows deleted the gomod branch March 12, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants