update status code if action returns error #142
Conversation
whisk/activation.go
Outdated
| return nil, resp, err | ||
| } | ||
|
|
||
| if a.Success == false { |
There was a problem hiding this comment.
you could remove this predicate here and instead assign code = 0 for the default case in the switch below.
whisk/activation.go
Outdated
| return a, resp, nil | ||
| } | ||
|
|
||
| func GetStatusCodeForErrorMessage(msg string) (int) { |
There was a problem hiding this comment.
I suppose it's ok to have this function be public.
You can unit test just this function.
Note that to incorporate this fix into the wsk CLI, we'll need to bump the godep https://github.com/apache/openwhisk-cli/blob/678deee9510abac72b84c7f3ad98a0f58b97443e/Godeps/Godeps.json#L9
|
@ShubhamGupta9582 this failed in CI: I think there's a formatting error. You can run |
|
@rabbah I ran EDIT: How can i produce |
|
Thanks @ShubhamGupta9582 for the contribution. |
2 participants
This PR is a fix for the issue which i raised for the activation's
statusCode.For more details about the issue, please click here
I have updated
statusCodeon the basis ofstatusSo that we can get correctstatusCodeaccording tostatus.