handle err return from url.Parse in GetUrlBase #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabbah
approved these changes
Jun 29, 2019
This is an attempt to fix wskdeploy issue 1050, which reported a crash in wskdeploy when the apihost was a raw host:port without a scheme.
dgrove-oss
force-pushed
the
wskdeploy-1050
branch
from
c66d0ed to
af3682f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix wskdeploy issue apache/openwhisk-wskdeploy#1050
which reported a crash in wskdeploy when the apihost
was a raw host:port without a scheme.