Skip to content

Comments

refactor(services/rocksdb): split rocksdb service as a crate#7081

Merged
koushiro merged 11 commits intoapache:mainfrom
KarinaMilet:rocksdb
Dec 22, 2025
Merged

refactor(services/rocksdb): split rocksdb service as a crate#7081
koushiro merged 11 commits intoapache:mainfrom
KarinaMilet:rocksdb

Conversation

@KarinaMilet
Copy link
Contributor

Which issue does this PR close?

Closes #6919.
Tracking issue: #6829

Rationale for this change

Split core/core/src/services/rocksdb into a single crate(RFC-6828).

What changes are included in this PR?

  • Moved rocksdb implementation from core/core/src/services/rocksdb to core/services/rocksdb.
  • Created a new crate opendal-service-rocksdb.
  • Updated opendal-core to remove rocksdb logic and dependencies.
  • Updated opendal to re-export rocksdb service from the new crate.

Are there any user-facing changes?

No. The public API opendal::services::rocksdb remains unchanged.

AI Usage Statement

Tab completion provided by Github copilot.

@KarinaMilet KarinaMilet requested a review from Xuanwo as a code owner December 21, 2025 13:30
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" labels Dec 21, 2025
Copy link
Member

@koushiro koushiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 22, 2025
@koushiro koushiro merged commit 0ebefe6 into apache:main Dec 22, 2025
334 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[core split] Service: rocksdb

2 participants