refactor: split concurrent-limit layer as a crate#7073
Merged
Conversation
Signed-off-by: Chojan Shang <[email protected]>
dosubot
bot
added
size:M
There was a problem hiding this comment.
Pull request overview
This PR refactors the concurrent-limit layer by extracting it into its own crate (opendal-layer-concurrent-limit) as part of the ongoing effort to split layers in the repository. This follows the same pattern used by other layers like chaos, capability-check, and async-backtrace.
Key changes:
- Created a new standalone crate for the concurrent-limit layer with its own Cargo.toml
- Updated import paths from
crate::*toopendal_core::*to reference the core crate externally - Updated documentation examples to use the new crate name (
opendal_layer_concurrent_limit::ConcurrentLimitLayer) - Added the new crate to default features and integrated it into the main opendal crate
- Removed the old module from
core/core/src/layers/mod.rs
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| core/src/lib.rs | Added re-export for the new opendal-layer-concurrent-limit crate under the layers module |
| core/layers/concurrent-limit/src/lib.rs | Updated imports from crate-relative to opendal_core and updated documentation examples to reference the new crate name |
| core/layers/concurrent-limit/Cargo.toml | New Cargo.toml configuration for the standalone concurrent-limit layer crate with proper dependencies |
| core/core/src/layers/mod.rs | Removed the old concurrent_limit module that was previously part of the core crate |
| core/Cargo.toml | Added concurrent-limit layer to features, default features, and dependencies in alphabetical order |
| core/Cargo.lock | Updated lock file to reflect the new opendal-layer-concurrent-limit dependency and its transitive dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
koushiro
approved these changes
Dec 20, 2025
Member
koushiro
left a comment
koushiro
left a comment
There was a problem hiding this comment.
LGTM, but it seems there's a problem with the prefix list operation of gdrive service in CI; perhaps we need to merge the latest main branch to include the relevant latest fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6934 .
Rationale for this change
Part of #6829 .
What changes are included in this PR?
Extract
ConcurrentLimitLayerinto its own crate to align with the repository’s split-layer architecture.Are there any user-facing changes?
No public API changes.
AI Usage Statement
codex, gpt-5.2-codex (high)