refactor: split sftp service into a separate crate#7060
Merged
koushiro merged 15 commits intoapache:mainfrom Dec 20, 2025
Merged
refactor: split sftp service into a separate crate#7060koushiro merged 15 commits intoapache:mainfrom
koushiro merged 15 commits intoapache:mainfrom
Conversation
Contributor
Author
|
@koushiro hey how can i fix (failing checks |
koushiro
reviewed
Dec 20, 2025
koushiro
reviewed
Dec 20, 2025
Member
You only need to care about the doc-test of Core CI. |
Co-authored-by: Qinxuan Chen <[email protected]>
koushiro
approved these changes
Dec 20, 2025
Member
koushiro
left a comment
There was a problem hiding this comment.
Thanks for your contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6921
Tracking issue: #6829
Rationale for this change
This PR splits the sftp service out of opendal-core into its own crate
opendal-service-sftpas part of the core-split effort (RFC-6828). This helps in modularizing the codebase and reducing the compilation time and dependencies for the core crate.What changes are included in this PR?
core/src/services/sftptocore/services/sftp.opendal-service-sftp.opendal-coreto remove sftp logic and dependencies (openssh,openssh-sftp-client).opendal(facade) to re-export sftp service from the new crate.From<SftpMeta>usage to a static helper function to satisfy Rust orphan rules.core/services/sftp/Cargo.toml.Are there any user-facing changes?
No. The public API remains unchanged as
opendal::services::Sftpis re-exported via the facade crate.AI Usage Statement
This PR was built with the assistance of Google Gemini 3 pro