refactor: split swift service into a separate crate#7054
Merged
koushiro merged 4 commits intoapache:mainfrom Dec 18, 2025
Merged
refactor: split swift service into a separate crate#7054koushiro merged 4 commits intoapache:mainfrom
koushiro merged 4 commits intoapache:mainfrom
Conversation
dosubot
bot
added
size:L
…age, and remove blank lines.
Member
|
Hi @Sahil-Shadwal , you need to update |
koushiro
reviewed
Dec 17, 2025
Co-authored-by: Qinxuan Chen <[email protected]>
Member
|
Another question: I know you're using Gemini 3 Pro, but what tool are you using to run it? gemini-cli or something else? Also, are you directly using the prompts in #6829? |
Contributor
Author
naah i saw promts later , at first i just checked similar pr and then asked gemini to do similar things |
koushiro
approved these changes
Dec 18, 2025
koushiro
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6925
Tracking #6829
Rationale for this change
This change is part of the
core-spliteffort to split services out ofcoreinto their own crates. Segregating services helps improve compilation times and maintainability.What changes are included in this PR?
opendal-service-swiftincore/services/swift.swiftservice implementation fromcore/core/src/services/swiftto the new crate.core/Cargo.toml(workspace) to include the new service.core/core/Cargo.toml(opendal-core) to remove theswiftmodule and dependencies.opendal-service-swift/Cargo.tomlwith necessary dependencies (opendal-core,quick-xml,anyhow, etc.).opendal_coreinternal types where necessary.Are there any user-facing changes?
No. The public API remains compatible via re-exports in the main
opendalcrate. This is a purely internal refactoring.AI Usage Statement
This PR was built with the assistance of Google Gemini 3 pro