refactor: Split upyun service to new crate#7048
Merged
Conversation
dosubot
bot
added
size:L
There was a problem hiding this comment.
Pull request overview
This PR refactors the Upyun service implementation by extracting it from the monolithic opendal-core crate into its own separate opendal-service-upyun crate, following the pattern established by other recently refactored services like S3, TiKV, and others.
Key changes:
- Extracted Upyun service into
opendal-service-upyuncrate undercore/services/upyun/ - Updated all imports from
crate::*toopendal_core::*throughout the service code - Moved dependencies (hmac, sha1, md-5) from core to the new service crate
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| core/src/lib.rs | Added re-export for the new opendal-service-upyun crate |
| core/services/upyun/Cargo.toml | New Cargo manifest for the standalone upyun service crate |
| core/services/upyun/src/*.rs | Updated imports from crate::* to opendal_core::* |
| core/services/upyun/src/docs.md | Updated documentation example to use new crate path |
| core/core/src/services/mod.rs | Removed upyun module from core services |
| core/core/Cargo.toml | Removed upyun-specific dependencies (hmac, sha1) |
| core/Cargo.toml | Updated services-upyun feature to depend on new crate |
| core/Cargo.lock | Added new opendal-service-upyun package entry |
Comments suppressed due to low confidence (1)
core/services/upyun/src/lib.rs:21
- The module-level doc comment should be placed after the crate-level attributes for consistency with other service crates like s3. The recommended order is:
#![cfg_attr(docsrs, feature(doc_cfg))], then//! doc comment, then#![deny(missing_docs)].
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Xuanwo
approved these changes
Dec 17, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for working on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #6829
Closes #6927
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
AI Usage Statement
Zed with GPT-5.1 Codex-Max