refactor: Split pcloud service to new crate#7047
Merged
Conversation
dosubot
bot
added
size:L
There was a problem hiding this comment.
Pull request overview
This PR refactors the pCloud service implementation by extracting it from the monolithic core into a separate opendal-service-pcloud crate, following the established pattern for other OpenDAL service implementations.
Key Changes:
- Created new
opendal-service-pcloudcrate with its own Cargo.toml - Updated all import statements from
crate::*toopendal_core::*throughout the pcloud service code - Migrated the
services-pcloudfeature flag fromopendal-coreto the maincorecrate
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| core/services/pcloud/Cargo.toml | New crate manifest defining the pcloud service package with dependencies on opendal-core |
| core/services/pcloud/src/lib.rs | Updated module documentation and service registration to use external opendal_core references |
| core/services/pcloud/src/backend.rs | Changed imports from crate-relative to opendal_core external dependency |
| core/services/pcloud/src/config.rs | Updated imports and improved test error handling with Result return types |
| core/services/pcloud/src/core.rs | Changed imports from crate-relative to opendal_core external dependency |
| core/services/pcloud/src/deleter.rs | Changed imports from crate-relative to opendal_core external dependency |
| core/services/pcloud/src/error.rs | Changed imports from crate-relative to opendal_core external dependency |
| core/services/pcloud/src/lister.rs | Changed imports and fully qualified oio::Entry usage |
| core/services/pcloud/src/writer.rs | Changed imports from crate-relative to opendal_core external dependency |
| core/services/pcloud/src/docs.md | Updated example code to import Pcloud from opendal_service_pcloud instead of opendal_core::services |
| core/core/src/services/mod.rs | Removed pcloud module declaration as it's now an external crate |
| core/core/Cargo.toml | Removed services-pcloud feature flag from opendal-core |
| core/src/lib.rs | Added re-export of opendal_service_pcloud under services module |
| core/Cargo.toml | Updated services-pcloud feature to depend on external crate and added opendal-service-pcloud dependency |
| core/Cargo.lock | Added opendal-service-pcloud package entry with its dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #6829
Closes #6915
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
AI Usage Statement
Zed with GPT-5.1 Codex-Max