refactor: Split lakefs service to new crate#7046
Merged
Conversation
dosubot
bot
added
size:L
There was a problem hiding this comment.
Pull request overview
This PR refactors the lakeFS service implementation by extracting it from the monolithic core module into a standalone crate (opendal-service-lakefs), following the pattern established by other service implementations like IPFS and memcached.
Key Changes:
- Created new
opendal-service-lakefscrate with its own Cargo.toml - Updated imports across all lakeFS source files to use
opendal_core::*instead ofcrate::* - Modified feature flags and dependencies in parent crates to reference the new standalone crate
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| core/services/lakefs/Cargo.toml | New Cargo manifest for the standalone lakefs service crate |
| core/services/lakefs/src/lib.rs | Updated to serve as the crate root with proper module-level documentation and opendal_core registry integration |
| core/services/lakefs/src/backend.rs | Updated imports from crate::* to opendal_core::* |
| core/services/lakefs/src/writer.rs | Updated imports and added documentation comment for the writer struct |
| core/services/lakefs/src/lister.rs | Updated imports and added documentation comment for the lister struct |
| core/services/lakefs/src/deleter.rs | Updated imports and added documentation comment for the deleter struct |
| core/services/lakefs/src/core.rs | Updated imports and added documentation comment for the core struct |
| core/services/lakefs/src/error.rs | Updated imports in both main code and test module |
| core/services/lakefs/src/config.rs | Updated imports and simplified error construction; improved test functions to return Result |
| core/services/lakefs/src/docs.md | Updated example code to import from opendal_service_lakefs instead of opendal_core::services |
| core/core/src/services/mod.rs | Removed lakefs module declaration (moved to separate crate) |
| core/core/Cargo.toml | Removed services-lakefs feature flag from core crate |
| core/Cargo.toml | Updated services-lakefs feature to depend on new opendal-service-lakefs crate and added crate dependency |
| core/src/lib.rs | Added re-export of opendal_service_lakefs under services module |
| core/Cargo.lock | Added new opendal-service-lakefs package with its dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Xuanwo
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #6829
Closes #6905
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
AI Usage Statement
Zed with GPT-5.1 Codex-Max