Skip to content

Comments

refactor(services/gdrive): split gdrive into separate crate#7039

Merged
Xuanwo merged 3 commits intoapache:mainfrom
tao12345666333:refactor/split-service-gdrive
Dec 19, 2025
Merged

refactor(services/gdrive): split gdrive into separate crate#7039
Xuanwo merged 3 commits intoapache:mainfrom
tao12345666333:refactor/split-service-gdrive

Conversation

@tao12345666333
Copy link
Member

@tao12345666333 tao12345666333 commented Dec 16, 2025

This PR splits the gdrive service into its own crate opendal-service-gdrive.

  • Create new crate at core/services/gdrive
  • Update feature flag to use the new crate
  • Remove gdrive from opendal-core
  • Re-export from facade crate

Closes #6896

AI Usage Statement

Claude Code + Claude 4.5 Opus

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" labels Dec 16, 2025
format!("path not found: {path}"),
))?;

// The file metadata in the Google Drive API is very complex.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't remove the code comments.

}
}


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to run code format

This PR splits the gdrive service into its own crate `opendal-service-gdrive`.

- Create new crate at `core/services/gdrive`
- Update feature flag to use the new crate
- Remove gdrive from `opendal-core`
- Re-export from facade crate

Closes apache#6896
@tao12345666333 tao12345666333 force-pushed the refactor/split-service-gdrive branch from 2dddf35 to 049c2e5 Compare December 18, 2025 22:24
Restore all code comments that were accidentally removed during the
service split refactoring, as requested by reviewer.
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Dec 18, 2025
Update the example code in docs.md to use opendal_core and
opendal_service_gdrive instead of opendal, and add tokio as
dev-dependency for doc tests.
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Dec 18, 2025
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tao12345666333 for working on this!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 19, 2025
@Xuanwo Xuanwo merged commit ae8d9f7 into apache:main Dec 19, 2025
334 checks passed
@tao12345666333 tao12345666333 deleted the refactor/split-service-gdrive branch December 19, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[core split] Service: gdrive

2 participants