refactor: split monoiofs service into a separate crate by codxbrexx · Pull Request #7038 · apache/opendal

codxbrexx · 2025-12-16T22:09:50Z

Which issue does this PR close?

Part of #6829
Closes #6909

Rationale for this change

This PR extracts the monoiofs service from opendal-core into its own crate opendal-service-monoiofs as part of the core-split effort (RFC-6828). This improves modularity and compilation times by removing service-specific dependencies (like monoio, flume) from the core crate.

What changes are included in this PR?

Created a new crate core/services/monoiofs.
Moved all monoiofs source code from core/core/src/services/monoiofs to the new crate.
Removed monoiofs source and dependencies (monoio, flume) from opendal-core.
Updated opendal-core to remove the internal monoiofs module.
Updated the opendal facade to re-export Monoiofs from the new crate when the services-monoiofs feature is enabled.
Ensures all imports use opendal_core instead of crate.

Are there any user-facing changes?

No. The public API opendal::services::Monoiofs remains exactly the same for users of the library. Internally, the code location and dependency structure have changed.

AI Usage Statement

No.

core/core/Cargo.toml

…ng changes

… via surrealdb service

core/services/surrealdb/Cargo.toml

.github/actions/setup/action.yaml

core/core/Cargo.toml

core/core/src/services/mod.rs

koushiro · 2025-12-19T10:09:35Z

core/Cargo.lock

please revert irrelevant changes

Thanks for the review.

😕 You did not revert it; please do not run cargo update directly.

Thanks for the clarification. I’ll revert the Cargo.lock changes caused by cargo update and push an updated commit.

Co-authored-by: Qinxuan Chen <[email protected]>

koushiro · 2025-12-19T10:28:25Z

Hi @koushiro, I’m cleaning up the PR to revert the unrelated changes.

Quick confirmation: after splitting monoiofs into its own crate, should opendal-core still re-export it behind the existing feature flag, or should the old module references be removed entirely? Thanks.

You can get all you want to know from the prompts in #6829

bindings/ocaml/Cargo.toml

core/core/Cargo.toml

Co-authored-by: Qinxuan Chen <[email protected]>

koushiro

Mostly LGTM, but please revert the irrelevant changes in Cargo.lock

core/services/monoiofs/Cargo.toml

Co-authored-by: Qinxuan Chen <[email protected]>

codxbrexx

Applied change

koushiro · 2025-12-19T18:19:31Z

Applied change

No you didn't, are we really speaking the same language?
Why you upgrade and downgrade some deps in the Cargo.lock?

codxbrexx · 2025-12-19T18:59:28Z

Applied change

No you didn't, are we really speaking the same language? Why you upgrade and downgrade some deps in the Cargo.lock?

You’re right—sorry about that. I hadn’t fully reverted Cargo.lock.
I’ve now reset it to match origin/main exactly and pushed the update.

I’m currently stuck on the remaining Clippy errors and haven’t been able to resolve them correctly. Could you please point me in the right direction on how these are expected to be fixed in this refactor?

codxbrexx added 2 commits December 17, 2025 01:19

Service: monoiofs #6829

ccea45c

chore: update dependencies in Cargo.lock

faaf580

codxbrexx requested a review from Xuanwo as a code owner December 16, 2025 22:09

dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" labels Dec 16, 2025

codxbrexx added 3 commits December 17, 2025 03:55

Merge branch 'main' into issue-monoiofs

46d1838

chore: fix toml formatting

35199cb

chore: add license header and fix formatting

64bb63b

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Dec 16, 2025

chore: update lockfile

19b6739

Xuanwo reviewed Dec 17, 2025

View reviewed changes

core/core/Cargo.toml Outdated Show resolved Hide resolved

codxbrexx added 6 commits December 17, 2025 16:15

chore: remove incorrect monoiofs deps from core

7e4e50f

chore: sync with main

5daa114

Merge branch 'main' into issue-monoiofs

4571b1c

fix: pin async-graphql components to version 7.0.11 to prevent breaki…

dbcb95c

…ng changes

fix(core): taplo formatting in manifests; ensure async-graphql pinned…

144983a

… via surrealdb service

chore: taplo format core manifest

bbadd96

koushiro reviewed Dec 18, 2025

View reviewed changes

core/services/surrealdb/Cargo.toml Outdated Show resolved Hide resolved

koushiro reviewed Dec 18, 2025

View reviewed changes

.github/actions/setup/action.yaml Outdated Show resolved Hide resolved

codxbrexx added 4 commits December 18, 2025 16:15

Merge branch 'main' into issue-monoiofs

3d81264

chore: revert unnecessary async-graphql pins and update lockfile

cf172b4

chore: revert unrelated changes in setup action

ea019c8

Merge branch 'main' into issue-monoiofs

758256c

koushiro reviewed Dec 19, 2025

View reviewed changes

core/core/Cargo.toml Outdated Show resolved Hide resolved

koushiro reviewed Dec 19, 2025

View reviewed changes

core/core/Cargo.toml Outdated Show resolved Hide resolved

koushiro reviewed Dec 19, 2025

View reviewed changes

core/core/src/services/mod.rs Outdated Show resolved Hide resolved

koushiro reviewed Dec 19, 2025

View reviewed changes

koushiro changed the title ~~Service: monoiofs #6829~~ refactor: split monoiofs service into a separate crate Dec 19, 2025

Update core/core/Cargo.toml

3ed7173

Co-authored-by: Qinxuan Chen <[email protected]>

Update core/core/Cargo.toml

8ac8f52

Co-authored-by: Qinxuan Chen <[email protected]>

codxbrexx added 3 commits December 19, 2025 17:39

fix: resolve ci issues (formatting, ocaml deps, lockfile)

bf624a7

Merge branch 'main' into issue-monoiofs

7d6c8ab

ci: rerun checks

e88b35e

koushiro reviewed Dec 19, 2025

View reviewed changes

bindings/ocaml/Cargo.toml Outdated Show resolved Hide resolved

koushiro reviewed Dec 19, 2025

View reviewed changes

core/core/Cargo.toml Outdated Show resolved Hide resolved

codxbrexx and others added 3 commits December 19, 2025 21:48

Update bindings/ocaml/Cargo.toml

32d7e62

Co-authored-by: Qinxuan Chen <[email protected]>

Update core/core/Cargo.toml

f694f5a

Co-authored-by: Qinxuan Chen <[email protected]>

Merge branch 'main' into issue-monoiofs

55f4f28

koushiro reviewed Dec 19, 2025

View reviewed changes

core/services/monoiofs/Cargo.toml Outdated Show resolved Hide resolved

codxbrexx and others added 6 commits December 19, 2025 22:11

Apply suggestions from code review

14a87b3

Co-authored-by: Qinxuan Chen <[email protected]>

chore: revert Cargo.lock to match main

a56d03c

style: remove trailing comma

fe51e75

chore: Reformat futures dependency features in Cargo.toml

badcb76

Merge branch 'main' into issue-monoiofs

1c2659a

style: format toml files

c0ebaf1

codxbrexx commented Dec 19, 2025

View reviewed changes

Revert Cargo.lock dependency changes

3706a1f

codxbrexx force-pushed the issue-monoiofs branch from a931032 to 3706a1f Compare December 19, 2025 18:47

Revert unintended Cargo.lock dependency changes

74403d8

koushiro added 2 commits December 20, 2025 11:01

revert changes in Cargo.lock

bd42a69

update monoiofs service

3524b41

koushiro approved these changes Dec 20, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 20, 2025

koushiro merged commit 2ee38aa into apache:main Dec 20, 2025
335 checks passed

codxbrexx deleted the issue-monoiofs branch December 20, 2025 09:44

Comments

Conversation

codxbrexx commented Dec 16, 2025 • edited by koushiro Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

AI Usage Statement

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

koushiro Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

codxbrexx Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

koushiro Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

codxbrexx Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

koushiro commented Dec 19, 2025

Uh oh!

Uh oh!

Uh oh!

koushiro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codxbrexx left a comment

Choose a reason for hiding this comment

Uh oh!

koushiro commented Dec 19, 2025

Uh oh!

codxbrexx commented Dec 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codxbrexx commented Dec 16, 2025 •

edited by koushiro

Loading