refactor: Split seafile service into a separate crate#7029
Merged
koushiro merged 3 commits intoapache:mainfrom Dec 18, 2025
Merged
refactor: Split seafile service into a separate crate#7029koushiro merged 3 commits intoapache:mainfrom
koushiro merged 3 commits intoapache:mainfrom
Conversation
dosubot
bot
added
size:L
dosubot
bot
added
size:M
Member
|
Hi, please fill the AI Usage Statement |
Contributor
Author
|
@Xuanwo the reason for fail of OpamSolution.Fetch_fail in BInding OCaml is hash mismatch should i create a issue and add this to yml or just add it here? |
koushiro
reviewed
Dec 17, 2025
Co-authored-by: Qinxuan Chen <[email protected]>
koushiro
approved these changes
Dec 18, 2025
koushiro
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6920
Tracking issue: #6829
Rationale for this change
This PR splits the seafile service out of
coreinto its own crateopendal-service-seafileas part of the core-split effort (RFC-6828). This modularizes the codebase and allows for better dependency management.What changes are included in this PR?
core/src/services/seafileto new crate atcore/services/seafile.core/services/seafile/Cargo.tomlwith necessary dependencies.core/Cargo.tomlto addopendal-service-seafileto the workspace and dependencies.core/src/lib.rsto re-export theseafileservice.opendal-coreto remove the oldseafilemodule and feature flags.Are there any user-facing changes?
No. The public API and behavior remain unchanged as the service is re-exported from the wrapper crate.
AI Usage Statement
Tools: Copilot , gemini 3