refactor: Split dashmap service to new crate#7022
Merged
Conversation
dosubot
bot
added
size:L
There was a problem hiding this comment.
Pull request overview
This PR refactors the dashmap service implementation by extracting it from the monolithic opendal-core crate into a separate opendal-service-dashmap crate. This follows the ongoing pattern of modularizing services to improve build times and maintainability.
Key Changes:
- Created new
opendal-service-dashmapcrate with its own Cargo.toml - Updated all dashmap service source files to use
opendal_core::imports instead of relativecrate::imports - Removed dashmap-related dependencies and feature flags from
opendal-core
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| core/Cargo.toml | Updated services-dashmap feature to depend on the new opendal-service-dashmap crate and added the dependency (alphabetically ordered) |
| core/core/Cargo.toml | Removed dashmap dependency and services-dashmap feature flag from core crate |
| core/core/src/services/mod.rs | Removed dashmap module import as it's now in a separate crate |
| core/src/lib.rs | Added re-export for opendal_service_dashmap under the services-dashmap feature flag |
| core/services/dashmap/Cargo.toml | New crate manifest defining the standalone dashmap service package with necessary dependencies |
| core/services/dashmap/src/lib.rs | Updated to use opendal_core:: imports and added crate-level attributes for docs and lint enforcement |
| core/services/dashmap/src/backend.rs | Reorganized imports to use opendal_core:: instead of crate:: |
| core/services/dashmap/src/config.rs | Updated imports and improved test error handling with Result return types |
| core/services/dashmap/src/core.rs | Simplified imports to use opendal_core::* |
| core/services/dashmap/src/deleter.rs | Updated imports to reference opendal_core |
| core/services/dashmap/src/docs.md | Updated usage example to import from opendal_service_dashmap instead of opendal_core::services |
| core/services/dashmap/src/lister.rs | Reorganized imports and qualified Entry type with oio:: prefix for clarity |
| core/services/dashmap/src/writer.rs | Updated imports to use opendal_core and simplified local module imports |
| core/services/sqlite/Cargo.toml | Removed trailing newline for consistency |
| core/Cargo.lock | Reflected dependency changes with new opendal-service-dashmap package entry |
Comments suppressed due to low confidence (1)
core/services/dashmap/src/lib.rs:22
- The module-level doc comment should be placed after the crate attributes for consistency with other service crates. In similar services like cloudflare-kv and fs, the pattern is to have cfg_attr first, then the doc comment, then deny attributes. The current order places the doc comment before cfg_attr.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Xuanwo
approved these changes
Dec 16, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for working on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #6829
Closes #6888
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
AI Usage Statement
Zed with GPT-5.1 Codex-Max