refactor(services/sqlite): split sqlite service into separate crate#7014
Merged
Xuanwo merged 2 commits intoapache:mainfrom Dec 15, 2025
Merged
Conversation
dosubot
bot
added
size:L
yueneiqi
force-pushed
the
refactor/services-sqlite-split-crate
branch
from
d62c67a to
b103e9b
Compare
Xuanwo
approved these changes
Dec 15, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for working on this!
Member
|
The only thing left is to resolve the conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6923.
Rationale for this change
Relates to #6829.
What changes are included in this PR?
This PR extracts the sqlite service implementation from
opendal-coreinto a standalone crateopendal-service-sqlite, while keeping the public surfaceopendal::services::Sqliteunchanged.services-sqliteintact.opendal-core.ouroboros:ouroboroswas only an optional dep behind opendal-core’s old services-sqlite feature, but the sqlite implementation doesn’t reference it (no ouroboros usage in the sqlite code path), so after extracting sqlite into opendal-service-sqlite there’s no reason to keep that dependency.ouroboros_macroandproc-macro2-diagnosticswere pulled in transitively by ouroboros; once ouroboros is gone, Cargo drops those crates from core/Cargo.lock as well.Are there any user-facing changes?
AI Usage Statement
This PR was primarily authored with Codex (with
gpt-5.2) and then hand-reviewed by me. I AM responsible for every change made in this PR. I aimed to keep it aligned with our goals, though I may have missed minor issues. Please flag anything that feels off, I'll fix it quickly.