Skip to content

Comments

refactor: Split service tikv to new crate#6997

Merged
Xuanwo merged 1 commit intoapache:mainfrom
fenfeng9:refactor/split-tikv-service
Dec 12, 2025
Merged

refactor: Split service tikv to new crate#6997
Xuanwo merged 1 commit intoapache:mainfrom
fenfeng9:refactor/split-tikv-service

Conversation

@fenfeng9
Copy link
Contributor

Which issue does this PR close?

Closes #6926.

Rationale for this change

Part of #6829. This PR completes the task for the postgresql service.

What changes are included in this PR?

Add tikv service crate (moved code from core)

Are there any user-facing changes?

AI Usage Statement

Codex (with gpt-5.1-codex-max high)

@fenfeng9 fenfeng9 requested a review from Xuanwo as a code owner December 12, 2025 13:44
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" labels Dec 12, 2025
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for working on this.

The only thing left is resovle the conflicts.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 12, 2025
@fenfeng9 fenfeng9 force-pushed the refactor/split-tikv-service branch from d4ce2bd to e7ecfdd Compare December 12, 2025 14:52
@fenfeng9 fenfeng9 requested a review from Xuanwo December 12, 2025 15:16
@Xuanwo Xuanwo merged commit 1090028 into apache:main Dec 12, 2025
332 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[core split] Service: tikv

2 participants