refactor(services/onedrive): split into separate crate#6996
Merged
Xuanwo merged 3 commits intoapache:mainfrom Dec 18, 2025
Merged
refactor(services/onedrive): split into separate crate#6996Xuanwo merged 3 commits intoapache:mainfrom
Xuanwo merged 3 commits intoapache:mainfrom
Conversation
dosubot
bot
added
size:L
XYenon
force-pushed
the
refactor/onedrive/amp-free
branch
from
da2fe76 to
f4e05fa
Compare
Xuanwo
reviewed
Dec 12, 2025
core/services/onedrive/src/mod.rs
Outdated
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| pub use crate::{ |
Member
There was a problem hiding this comment.
What's this for? Why we need a mod.rs here?
XYenon
force-pushed
the
refactor/onedrive/amp-free
branch
from
f4e05fa to
0bcf2b9
Compare
Xuanwo
approved these changes
Dec 14, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for working on this!
Extract OneDrive service into its own crate 'opendal-service-onedrive' while maintaining the public API surface 'opendal::services::onedrive' through the facade. Changes: - Create new crate at core/services/onedrive/ with full service implementation - Update imports from crate::* to opendal_core::* in service code - Remove onedrive module from core/core/src/services/mod.rs - Update root Cargo.toml to depend on opendal-service-onedrive with feature gate - Add facade re-export in core/src/lib.rs to preserve public API - Fix documentation examples to import from opendal_service_onedrive crate - All tests pass, clippy checks pass, public API preserved
XYenon
force-pushed
the
refactor/onedrive/amp-free
branch
from
0bcf2b9 to
bf2c35f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6912.
#6829
Rationale for this change
Move services onedrive out as a new crate.
What changes are included in this PR?
Extract OneDrive service into its own crate 'opendal-service-onedrive' while maintaining the public API surface 'opendal::services::onedrive' through the facade.
Changes:
Are there any user-facing changes?
AI Usage Statement
https://ampcode.com/threads/T-019b1292-a7dc-7208-858f-578a34de1913