refactor(services/ipfs): extract ipfs service into separate crate#6991
Merged
Xuanwo merged 1 commit intoapache:mainfrom Dec 12, 2025
Merged
refactor(services/ipfs): extract ipfs service into separate crate#6991Xuanwo merged 1 commit intoapache:mainfrom
Xuanwo merged 1 commit intoapache:mainfrom
Conversation
Xuanwo
approved these changes
Dec 12, 2025
Member
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for working on this!
Member
|
The only thing left is resolving the conflicts. |
- Create new crate opendal-service-ipfs at core/services/ipfs/ - Move source files from core/core/src/services/ipfs/ to new crate - Update imports from crate:: to opendal_core:: - Add optional dependency in core/Cargo.toml - Update services-ipfs feature to use dep:opendal-service-ipfs - Add facade re-export in core/src/lib.rs - Remove services-ipfs feature from core/core/Cargo.toml The public API (opendal::services::Ipfs, opendal::services::IpfsConfig) and feature flag (services-ipfs) remain unchanged.
0ea550b to
7a288e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6902.
#6829
Rationale for this change
Move services ipfs out as a new crate.
What changes are included in this PR?
The public API (opendal::services::Ipfs, opendal::services::IpfsConfig) and feature flag (services-ipfs) remain unchanged.
Are there any user-facing changes?
AI Usage Statement
Antigravity with Claude Opus 4.5