Skip to content

Comments

refactor(services/ipfs): extract ipfs service into separate crate#6991

Merged
Xuanwo merged 1 commit intoapache:mainfrom
XYenon:refactor/ipfs
Dec 12, 2025
Merged

refactor(services/ipfs): extract ipfs service into separate crate#6991
Xuanwo merged 1 commit intoapache:mainfrom
XYenon:refactor/ipfs

Conversation

@XYenon
Copy link
Contributor

@XYenon XYenon commented Dec 12, 2025

Which issue does this PR close?

Closes #6902.

#6829

Rationale for this change

Move services ipfs out as a new crate.

What changes are included in this PR?

  • Create new crate opendal-service-ipfs at core/services/ipfs/
  • Move source files from core/core/src/services/ipfs/ to new crate
  • Update imports from crate:: to opendal_core::
  • Add optional dependency in core/Cargo.toml
  • Update services-ipfs feature to use dep:opendal-service-ipfs
  • Add facade re-export in core/src/lib.rs
  • Remove services-ipfs feature from core/core/Cargo.toml

The public API (opendal::services::Ipfs, opendal::services::IpfsConfig) and feature flag (services-ipfs) remain unchanged.

Are there any user-facing changes?

AI Usage Statement

Antigravity with Claude Opus 4.5

@XYenon XYenon requested a review from Xuanwo as a code owner December 12, 2025 10:25
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" labels Dec 12, 2025
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 12, 2025
@Xuanwo
Copy link
Member

Xuanwo commented Dec 12, 2025

The only thing left is resolving the conflicts.

- Create new crate opendal-service-ipfs at core/services/ipfs/
- Move source files from core/core/src/services/ipfs/ to new crate
- Update imports from crate:: to opendal_core::
- Add optional dependency in core/Cargo.toml
- Update services-ipfs feature to use dep:opendal-service-ipfs
- Add facade re-export in core/src/lib.rs
- Remove services-ipfs feature from core/core/Cargo.toml

The public API (opendal::services::Ipfs, opendal::services::IpfsConfig)
and feature flag (services-ipfs) remain unchanged.
@Xuanwo Xuanwo merged commit 92a33e7 into apache:main Dec 12, 2025
331 of 332 checks passed
@XYenon XYenon deleted the refactor/ipfs branch December 13, 2025 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[core split] Service: ipfs

2 participants