refactor: Split service b2 out of core#6982
Merged
Xuanwo merged 1 commit intoapache:mainfrom Dec 16, 2025
Merged
Conversation
dosubot
bot
added
size:M
Member
|
Hi, please fill the |
tao12345666333
added a commit
to tao12345666333/incubator-opendal
that referenced
this pull request
Dec 12, 2025
The 2.8.0 version has a bug with the cfg condition that causes clippy to fail with 'unexpected cfg condition name' errors. Upgrading to 2.11.1 resolves this issue. This fix resolves CI failures in PR apache#6982.
tao12345666333
added a commit
to tao12345666333/incubator-opendal
that referenced
this pull request
Dec 12, 2025
1. benches/types/buffer.rs: Replace loop with while let for better readability
- Lines 103-105: Changed loop { let Some(_) = buffer.next() else { break } }
to while let Some(_) = buffer.next() {}
- Lines 113-115: Same change for consistency
2. core/src/services/mod.rs: Fix code formatting
- Remove extra blank line between alluxio and cacache blocks
- Ensures consistent formatting across all service modules
Xuanwo
reviewed
Dec 12, 2025
Member
Author
|
Updated the AI usage statement in the PR description with the tools used and manual review notes. Thanks for the reminder! |
tao12345666333
added a commit
to tao12345666333/incubator-opendal
that referenced
this pull request
Dec 12, 2025
The 2.8.0 version has a bug with the cfg condition that causes clippy to fail with 'unexpected cfg condition name' errors. Upgrading to 2.11.1 resolves this issue. This fix resolves CI failures in PR apache#6982.
tao12345666333
force-pushed
the
vibe-b2
branch
from
bd5ceaf to
c744618
Compare
tao12345666333
added a commit
to tao12345666333/incubator-opendal
that referenced
this pull request
Dec 12, 2025
1. benches/types/buffer.rs: Replace loop with while let for better readability
- Lines 103-105: Changed loop { let Some(_) = buffer.next() else { break } }
to while let Some(_) = buffer.next() {}
- Lines 113-115: Same change for consistency
2. core/src/services/mod.rs: Fix code formatting
- Remove extra blank line between alluxio and cacache blocks
- Ensures consistent formatting across all service modules
tao12345666333
added a commit
to tao12345666333/incubator-opendal
that referenced
this pull request
Dec 12, 2025
The 2.8.0 version has a bug with the cfg condition that causes clippy to fail with 'unexpected cfg condition name' errors. Upgrading to 2.11.1 resolves this issue. This fix resolves CI failures in PR apache#6982.
tao12345666333
force-pushed
the
vibe-b2
branch
from
91b4569 to
a134727
Compare
tao12345666333
added a commit
to tao12345666333/incubator-opendal
that referenced
this pull request
Dec 12, 2025
1. benches/types/buffer.rs: Replace loop with while let for better readability
- Lines 103-105: Changed loop { let Some(_) = buffer.next() else { break } }
to while let Some(_) = buffer.next() {}
- Lines 113-115: Same change for consistency
2. core/src/services/mod.rs: Fix code formatting
- Remove extra blank line between alluxio and cacache blocks
- Ensures consistent formatting across all service modules
tao12345666333
force-pushed
the
vibe-b2
branch
from
a8f0314 to
04a6ee1
Compare
tao12345666333
added a commit
to tao12345666333/incubator-opendal
that referenced
this pull request
Dec 12, 2025
The 2.8.0 version has a bug with the cfg condition that causes clippy to fail with 'unexpected cfg condition name' errors. Upgrading to 2.11.1 resolves this issue. This fix resolves CI failures in PR apache#6982.
tao12345666333
added a commit
to tao12345666333/incubator-opendal
that referenced
this pull request
Dec 12, 2025
1. benches/types/buffer.rs: Replace loop with while let for better readability
- Lines 103-105: Changed loop { let Some(_) = buffer.next() else { break } }
to while let Some(_) = buffer.next() {}
- Lines 113-115: Same change for consistency
2. core/src/services/mod.rs: Fix code formatting
- Remove extra blank line between alluxio and cacache blocks
- Ensures consistent formatting across all service modules
dosubot
bot
added
size:XXL
Xuanwo
reviewed
Dec 14, 2025
Member
|
It seems better for Minimax M2 to restart this work 😆 |
tao12345666333
force-pushed
the
vibe-b2
branch
from
052e0ce to
ebbdf00
Compare
dosubot
bot
added
size:L
Signed-off-by: Jintao Zhang <[email protected]>
tao12345666333
force-pushed
the
vibe-b2
branch
from
ebbdf00 to
98bf6d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6882
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
AI Usage Statement
This patch series was prepared with assistance from Claude Code and Minimax M2 to draft refactors and scaffolding; all changes were reviewed and adjusted manually before submission.