Skip to content

Comments

refactor: split oss service to new crate#6978

Merged
Xuanwo merged 4 commits intoapache:mainfrom
ButterBright:main
Dec 14, 2025
Merged

refactor: split oss service to new crate#6978
Xuanwo merged 4 commits intoapache:mainfrom
ButterBright:main

Conversation

@ButterBright
Copy link
Member

@ButterBright ButterBright commented Dec 11, 2025

Which issue does this PR close?

Closes #6914.
Related to #6829.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

AI Usage Statement

GitHub Copilot + Claude Opus 4.5

@ButterBright ButterBright requested a review from Xuanwo as a code owner December 11, 2025 14:19
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" labels Dec 11, 2025
@Xuanwo
Copy link
Member

Xuanwo commented Dec 12, 2025

Hi, could you place update the AI Usage Statement?

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other changes LGTM

use opendal_core::raw::*;
use opendal_core::*;

static GLOBAL_REQWEST_CLIENT: LazyLock<reqwest::Client> = LazyLock::new(reqwest::Client::new);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the GLOBAL_REQWEST_CLIENT from opendal_core.


/// Aliyun Object Storage Service (OSS) support
#[doc = include_str!("docs.md")]
#[doc = include_str!("../docs.md")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

@ButterBright
Copy link
Member Author

Hi, could you place update the AI Usage Statement?

Updated.

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 14, 2025
@Xuanwo Xuanwo merged commit a9e400f into apache:main Dec 14, 2025
332 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[core split] Service: oss

2 participants