Skip to content

Comments

chore(services/vercel-blob): split crate from core#6971

Merged
Xuanwo merged 4 commits intoapache:mainfrom
kenwoodjw:feat/6929
Dec 11, 2025
Merged

chore(services/vercel-blob): split crate from core#6971
Xuanwo merged 4 commits intoapache:mainfrom
kenwoodjw:feat/6929

Conversation

@kenwoodjw
Copy link
Contributor

Which issue does this PR close?

Closes #6929 .

using GPT-5.1-Codex-Max, Extra high

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@kenwoodjw kenwoodjw requested a review from Xuanwo as a code owner December 11, 2025 09:47
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. releases-note/chore The PR has a title that begins with "chore" or changes other small things that hard to tell labels Dec 11, 2025
pub use vercel_artifacts::*;

#[cfg(feature = "services-vercel-blob")]
mod vercel_blob;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems code under vercel_blob is not removed. I didn't expect that we can see 1000 lines of changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the delete is not commit, let me commit

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Dec 11, 2025
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this! The only thing left is running cargo fmt

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 11, 2025
Signed-off-by: kenwoodjw <[email protected]>
@Xuanwo Xuanwo merged commit 2b4b7cd into apache:main Dec 11, 2025
330 of 331 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/chore The PR has a title that begins with "chore" or changes other small things that hard to tell size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[core split] Service: vercel-blob

2 participants