refactor: Split oteltrace layer to new crate#6969
Merged
Conversation
dosubot
bot
added
size:M
There was a problem hiding this comment.
Pull request overview
This PR refactors the OpenTelemetry trace layer by extracting it from the opendal-core crate into a new standalone crate opendal-layer-oteltrace. This change is part of the broader effort to modularize OpenDAL's layer system (refs #6829, #6944).
Key Changes:
- Extracted the
oteltracelayer implementation into a new crate atcore/layers/oteltrace - Updated import paths from internal
crate::*to externalopendal_core::*imports - Removed the
layers-otel-tracefeature andopentelemetrydependency fromopendal-core
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
core/layers/oteltrace/Cargo.toml |
New package manifest defining the standalone oteltrace layer crate with appropriate dependencies |
core/layers/oteltrace/src/lib.rs |
Updated imports to use opendal_core and revised documentation to reflect the new crate structure |
core/src/lib.rs |
Added re-export of opendal-layer-oteltrace under the layers-otel-trace feature flag |
core/core/src/layers/mod.rs |
Removed the internal oteltrace module declaration and export |
core/core/Cargo.toml |
Removed the layers-otel-trace feature definition and opentelemetry dependency |
core/Cargo.toml |
Updated layers-otel-trace feature to depend on the new opendal-layer-oteltrace crate |
core/Cargo.lock |
Added lock file entries for the new opendal-layer-oteltrace dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Xuanwo
reviewed
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
part of #6829
Closes #6944
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?