refactor: Split immutable-index layer to new crate#6967
Merged
Conversation
dosubot
bot
added
size:M
There was a problem hiding this comment.
Pull request overview
This PR successfully refactors the immutable-index layer from the core monolith into a separate crate (opendal-layer-immutable-index), following the ongoing pattern of extracting layers into independent crates.
Key changes:
- Created a new standalone crate for the immutable-index layer at
core/layers/immutable-index/ - Updated imports from
crate::*toopendal_core::*throughout the layer code - Added proper feature flag (
layers-immutable-index) and dependency configuration
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| core/src/lib.rs | Added re-export of the new immutable-index layer crate under the layers-immutable-index feature flag |
| core/layers/immutable-index/src/lib.rs | Updated imports from internal crate::* to external opendal_core::*, updated documentation examples, and removed the services-http feature flag from tests |
| core/layers/immutable-index/Cargo.toml | New Cargo manifest for the standalone layer crate with proper dependencies on opendal-core |
| core/core/src/layers/mod.rs | Removed the immutable-index module declaration as it's now an external crate |
| core/Cargo.toml | Added feature flag definition and dependency entry for the new layer crate |
| core/Cargo.lock | Updated lock file with the new package entry |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Xuanwo
reviewed
Dec 11, 2025
dosubot
bot
added
size:L
Xuanwo
approved these changes
Dec 12, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for working on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
part of #6829
Closes #6938
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?