Skip to content

Comments

refactor: Split fastrace layer to new crate#6965

Merged
koushiro merged 4 commits intomainfrom
extract-fastrace-layer
Dec 11, 2025
Merged

refactor: Split fastrace layer to new crate#6965
koushiro merged 4 commits intomainfrom
extract-fastrace-layer

Conversation

@koushiro
Copy link
Member

@koushiro koushiro commented Dec 11, 2025

Which issue does this PR close?

part of #6829

Closes #6937

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Copilot AI review requested due to automatic review settings December 11, 2025 04:38
@koushiro koushiro requested a review from Xuanwo as a code owner December 11, 2025 04:38
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" labels Dec 11, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the fastrace layer from being part of the core crate into a separate opendal-layer-fastrace crate, following the same pattern used for other layers like fastmetrics and metrics.

  • Moves fastrace layer implementation to core/layers/fastrace as a standalone crate
  • Updates feature flags and dependencies across core crates to reference the new layer crate
  • Updates documentation examples to use the new import path opendal_layer_fastrace::FastraceLayer

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
core/src/lib.rs Adds re-export for the new opendal-layer-fastrace crate under the layers-fastrace feature
core/layers/fastrace/src/lib.rs Updates imports from crate::* to opendal_core::* and adjusts documentation examples to reflect new crate structure
core/layers/fastrace/Cargo.toml Creates new crate configuration with dependencies on opendal-core and fastrace
core/core/src/layers/mod.rs Removes the fastrace module from core as it's now a separate crate
core/core/Cargo.toml Removes fastrace-related dependencies and feature flags from the core crate
core/Cargo.toml Updates layers-fastrace feature to depend on the new opendal-layer-fastrace crate and adds it to dependencies
core/Cargo.lock Reflects the dependency changes with new opendal-layer-fastrace package entry

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 11, 2025
@koushiro koushiro merged commit c60c3ad into main Dec 11, 2025
389 checks passed
@koushiro koushiro deleted the extract-fastrace-layer branch December 11, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[core split] Layer: fastrace

2 participants