refactor: Split fastrace layer to new crate#6965
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the fastrace layer from being part of the core crate into a separate opendal-layer-fastrace crate, following the same pattern used for other layers like fastmetrics and metrics.
- Moves fastrace layer implementation to
core/layers/fastraceas a standalone crate - Updates feature flags and dependencies across core crates to reference the new layer crate
- Updates documentation examples to use the new import path
opendal_layer_fastrace::FastraceLayer
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| core/src/lib.rs | Adds re-export for the new opendal-layer-fastrace crate under the layers-fastrace feature |
| core/layers/fastrace/src/lib.rs | Updates imports from crate::* to opendal_core::* and adjusts documentation examples to reflect new crate structure |
| core/layers/fastrace/Cargo.toml | Creates new crate configuration with dependencies on opendal-core and fastrace |
| core/core/src/layers/mod.rs | Removes the fastrace module from core as it's now a separate crate |
| core/core/Cargo.toml | Removes fastrace-related dependencies and feature flags from the core crate |
| core/Cargo.toml | Updates layers-fastrace feature to depend on the new opendal-layer-fastrace crate and adds it to dependencies |
| core/Cargo.lock | Reflects the dependency changes with new opendal-layer-fastrace package entry |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Xuanwo
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
part of #6829
Closes #6937
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?