feat(layer): split TimeoutLayer into opendal-layer-timeout#6964
Closed
bytelazy wants to merge 2 commits intoapache:mainfrom
Closed
feat(layer): split TimeoutLayer into opendal-layer-timeout#6964bytelazy wants to merge 2 commits intoapache:mainfrom
bytelazy wants to merge 2 commits intoapache:mainfrom
Conversation
dosubot
bot
added
size:M
Xuanwo
reviewed
Dec 11, 2025
| ``` | ||
|
|
||
| It's also recommended to use opendal's [`TimeoutLayer`][crate::layers::TimeoutLayer] to prevent slow requests hangs forever. This layer will automatically cancel the request if it takes too long to complete. | ||
| It's also recommended to use opendal's [`TimeoutLayer`] to prevent slow requests hangs forever. This layer will automatically cancel the request if it takes too long to complete. |
| "env-filter", | ||
| "tracing-log", | ||
| ] } | ||
| opendal-layer-timeout = { path = "../layers/timeout", version = "0.55.0", default-features = false } |
Member
There was a problem hiding this comment.
core should not depend on this layer.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6950
This PR splits the layer retry out of core as part of the core-split effort and follows the tracking issue #6829.
Rationale for this change
What changes are included in this PR?
Extracted TimeoutLayer into the new opendal-layer-timeout crate while keeping its timeout behavior and tests intact for layered operations.
Wired the new crate into the workspace with the layers-timeout feature enabled by default and re-exported through the facade so opendal::layers::TimeoutLayer continues to work unchanged.
Exposed Executor::into_inner for cross-crate use and updated documentation and test helpers to align with the timeout layer split
Are there any user-facing changes?