refactor: Split service hdfs-native to new crate#6953
Merged
Xuanwo merged 4 commits intoapache:mainfrom Dec 8, 2025
Merged
Conversation
chitralverma
commented
Dec 8, 2025
| base64 = "0.22" | ||
| bytes = "1.10" | ||
| ctor = "0.6" | ||
| futures = { version = "0.3", default-features = false } |
Contributor
Author
There was a problem hiding this comment.
added futures as a workspace dependency
…into split-hdfs-native
dosubot
bot
added
size:L
Contributor
Author
|
@Xuanwo ready for your review |
There was a problem hiding this comment.
Pull request overview
This PR refactors the hdfs-native service from the monolithic opendal-core crate into a separate opendal-service-hdfs-native crate, continuing the modularization effort tracked in issue #6829.
- Extracts hdfs-native service implementation to
core/services/hdfs-native/ - Updates all imports to reference
opendal_coreinstead of localcrate:: - Adds
futuresas a workspace dependency and updates all dependent crates to use it - Improves function naming consistency (
register_hdfsnative_service→register_hdfs_native_service)
Reviewed changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| core/src/lib.rs | Adds re-export for the new opendal-service-hdfs-native crate under the services-hdfs-native feature |
| core/services/hdfs-native/Cargo.toml | Creates new crate manifest with dependencies for hdfs-native service |
| core/services/hdfs-native/src/*.rs | Updates all imports from crate:: to opendal_core:: for core types and crate::error for local error module |
| core/services/hdfs-native/src/lib.rs | Renames registration function to follow consistent naming convention |
| core/services/hdfs-native/src/docs.md | Removes documentation sections specific to monolithic crate context |
| core/core/src/services/mod.rs | Removes hdfs_native module declaration from core services |
| core/core/Cargo.toml | Removes services-hdfs-native feature and updates futures to workspace dependency |
| core/Cargo.toml | Adds futures workspace dependency and opendal-service-hdfs-native as optional dependency with corresponding feature flag |
| core/Cargo.lock | Updates lock file with new hdfs-native service crate |
| core/layers/await-tree/Cargo.toml | Updates futures dependency to use workspace reference |
| core/examples/*/Cargo.toml | Updates futures dependencies across example crates to use workspace reference |
| core/edge/file_write_on_full_disk/Cargo.toml | Updates futures dependency to use workspace reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Xuanwo
approved these changes
Dec 8, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for working on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6900.
Rationale for this change
Part of #6829. This PR completes the task for the hdfs-native service.
What changes are included in this PR?
futuresas a workspace dependencyAre there any user-facing changes?