refactor(services/http): Move services http out as a crate#6870
refactor(services/http): Move services http out as a crate#6870koushiro merged 7 commits intoapache:mainfrom
Conversation
dosubot
bot
added
size:L
|
|
||
| #[cfg(test)] | ||
| #[cfg(feature = "services-http")] | ||
| // Note: services-http feature is now in opendal facade crate, not opendal-core |
There was a problem hiding this comment.
This the case we need to avoid. Can you move this layer out first?
core/core/src/raw/oio/write/api.rs
Outdated
| impl Write for () { | ||
| async fn write(&mut self, _: Buffer) -> Result<()> { | ||
| unimplemented!("write is required to be implemented for oio::Write") | ||
| Err(Error::new( |
There was a problem hiding this comment.
We shouldn't touch unrelated code.
There was a problem hiding this comment.
Sure, thanks for head up.
dosubot
bot
added
size:M
|
I'm wondering how to resolve conflicts. I could not use web to edit , so I use git fetch origin and git merge origin/main, but there is a lot of upstream. |
Anyways, you'll need to start a new PR for moving immutable layer out first. |
|
Hi @0lai0, the immutable index layer has been split into a separate crate and does not depend on the HTTP service, can you resolve the conflicts? |
4 participants
Which issue does this PR close?
Part of #6829. This PR completes the task for the http service.
Rationale for this change
Move services http out as a new crate
What changes are included in this PR?
Following the RFC-6828 modularization strategy, we have moved the http service to a separate crate. This reduces opendal-core complexity and improves compilation speed for users not using this service
Are there any user-facing changes?
no