refactor(services/moka): Move services moka out as a crate#6868
Merged
Xuanwo merged 1 commit intoapache:mainfrom Dec 5, 2025
Merged
refactor(services/moka): Move services moka out as a crate#6868Xuanwo merged 1 commit intoapache:mainfrom
Xuanwo merged 1 commit intoapache:mainfrom
Conversation
dosubot
bot
added
size:XL
Xuanwo
reviewed
Dec 5, 2025
| pub use self::mini_moka::*; | ||
|
|
||
| #[cfg(feature = "services-moka")] | ||
| mod moka; |
Member
There was a problem hiding this comment.
Seems you didn't remove the files under moka?
Contributor
Author
There was a problem hiding this comment.
Yes, I forgot to delete it.
This commit extracts the moka service into its own crate, `opendal-service-moka`, following the established service splitting pattern. The changes primarily involve moving the source files and updating Cargo configurations accordingly. Signed-off-by: manchangfengxu <[email protected]>
manchangfengxu
force-pushed
the
feature/split-moka-service
branch
from
7bfd1c2 to
799be9b
Compare
dosubot
bot
added
size:L
Xuanwo
approved these changes
Dec 5, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Great, thank you for working on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit extracts the moka service into its own crate,
opendal-service-moka, following the established service splitting pattern.The changes primarily involve moving the source files and updating Cargo configurations accordingly.
Which issue does this PR close?
Part of #6829. This PR completes the task for the moka service.
Rationale for this change
This change is part of the ongoing effort to modularize OpenDAL services as outlined in RFC-6828. By splitting the
mokaservice into its own crate, we reduce the complexity and compile times ofopendal-corefor users who do not need this specific service.What changes are included in this PR?
opendal-service-mokaundercore/services/.mokaservice source code fromopendal-coreto the new crate.Cargo.tomlconfigurations to reflect the new workspace member, dependency, and feature flag.mokaservice is still exposed through theopendalfacade crate to maintain API compatibility.Are there any user-facing changes?
No, this is a refactoring.