Skip to content

Comments

fix:(bindings/python) Gate service-sftp on windows targets#6777

Merged
Xuanwo merged 2 commits intoapache:mainfrom
chitralverma:alt-gate-sftp
Nov 13, 2025
Merged

fix:(bindings/python) Gate service-sftp on windows targets#6777
Xuanwo merged 2 commits intoapache:mainfrom
chitralverma:alt-gate-sftp

Conversation

@chitralverma
Copy link
Contributor

@chitralverma chitralverma commented Nov 13, 2025

Which issue does this PR close?

Closes #6773

Rationale for this change

  • Gate SFTP service on windows targets

What changes are included in this PR?

Are there any user-facing changes?

windows users cannot use service-sftp

Include the sftp feature in services-all on non-windows targets.
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. releases-note/feat The PR implements a new feature or has a title that begins with "feat" labels Nov 13, 2025
@chitralverma chitralverma changed the title Conditionally include sftp feature fix:(bindings/python) Gate service-sftp on windows targets Nov 13, 2025
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @chitralverma for helping fix this!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 13, 2025
@Xuanwo Xuanwo merged commit c507e31 into apache:main Nov 13, 2025
60 checks passed
@chitralverma chitralverma deleted the alt-gate-sftp branch December 8, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/feat The PR implements a new feature or has a title that begins with "feat" size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: openssh failed to build on windows

2 participants