feat(binding/nodejs): add TimeoutLayer, LoggingLayer and ThrottleLayer in nodejs binding#6772
Merged
Xuanwo merged 3 commits intoapache:mainfrom Nov 14, 2025
Merged
Conversation
Kilerd
force-pushed
the
feat/add-layers-in-nodejs
branch
from
039ea72 to
92f8c09
Compare
Kilerd
force-pushed
the
feat/add-layers-in-nodejs
branch
from
92f8c09 to
77d6e02
Compare
dosubot
bot
added
size:XL
yihong0618
reviewed
Nov 12, 2025
bindings/nodejs/src/layer.rs
Outdated
| #[napi(constructor)] | ||
| pub fn new(bandwidth: u32, burst: u32) -> Self { | ||
| if bandwidth == 0 { | ||
| panic!("bandwidth must be greater than 0"); |
Contributor
There was a problem hiding this comment.
do we need this panic here?
bindings/nodejs/src/layer.rs
Outdated
| panic!("bandwidth must be greater than 0"); | ||
| } | ||
| if burst == 0 { | ||
| panic!("burst must be greater than 0"); |
Contributor
There was a problem hiding this comment.
ditto I search the node binding, seems no this kind of check
Member
There was a problem hiding this comment.
Yes, I suggest we just pass all value into rust core and don't add our own logic.
Contributor
Author
There was a problem hiding this comment.
I've removed the redundant checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
no related issue
Rationale for this change
Are there any user-facing changes?