Skip to content

Comments

refactor(core): remove conditional compilation in PageList trait#6715

Merged
Xuanwo merged 1 commit intoapache:mainfrom
crwen:refactor/pagelist-remove-cfg
Oct 21, 2025
Merged

refactor(core): remove conditional compilation in PageList trait#6715
Xuanwo merged 1 commit intoapache:mainfrom
crwen:refactor/pagelist-remove-cfg

Conversation

@crwen
Copy link
Contributor

@crwen crwen commented Oct 21, 2025

Which issue does this PR close?

remove conditional compilation in PageList trait

Closes #.

Rationale for this change

MaybeSend trait is an empty trait on wasm32 target, so it's not necessary to use conditional compilation

What changes are included in this PR?

remove conditional compilation in PageList trait

Are there any user-facing changes?

@crwen crwen requested a review from Xuanwo as a code owner October 21, 2025 06:35
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" labels Oct 21, 2025
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 21, 2025
@Xuanwo Xuanwo merged commit e06c833 into apache:main Oct 21, 2025
333 of 334 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/refactor The PR does a refactor on code or has a title that begins with "refactor" size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants