feat(services/gdrive): Implement write returns metadata#6683
feat(services/gdrive): Implement write returns metadata#6683erickguan merged 7 commits intoapache:mainfrom
Conversation
dosubot
bot
added
size:M
There was a problem hiding this comment.
Great, thank you! Just some documentation changes.
Optional: if you have made tests, can you add some test cases for models? An example is https://github.com/apache/opendal/blob/main/core/src/services/onedrive/graph_model.rs#L183
erickguan
left a comment
erickguan
left a comment
There was a problem hiding this comment.
Nice progress. Some last comments.
yunchipang
force-pushed
the
gdrive-write-returns-metadata
branch
from
dc6c07a to
e25e579
Compare
dosubot
bot
added
size:L
erickguan
left a comment
erickguan
left a comment
There was a problem hiding this comment.
Thank you so much for your contribution!
I noticed the behavior test fails both on main and this PR. Created #6684
Since this is not part of your PR or ticket. Do you want to merge this or do you want to fix the test first?
I will take a closer look if we can set modified time as optional.
yunchipang
force-pushed
the
gdrive-write-returns-metadata
branch
from
fbdfd75 to
e07d964
Compare
|
@erickguan thanks so much for reviewing! yes i'd like to merge this first if possible. |
|
Thanks for working on this. Let me know if you are interested in fixing the service for tests. |
|
Hitting errors like: ---- behavior::test_write_only ----
Unexpected (persistent) at write, context: { service: gdrive, path: 2598aedf-0a47-4feb-9509-0e2be776fae1 } => deserialize json, source: missing field `modifiedTime` at line 8 column 5
---- behavior::test_write_with_special_chars ----
Unexpected (persistent) at write, context: { service: gdrive, path: 6123d42b-5265-4ec7-874b-53167d218067 !@#$%^&()_+-=;',.txt } => deserialize json, source: missing field `modifiedTime` at line 8 column 5
---- behavior::test_write_returns_metadata ----
Unexpected (persistent) at write, context: { service: gdrive, path: 906b4dbb-08fb-4047-a859-ebb5bfcbb34f } => deserialize json, source: missing field `modifiedTime` at line 8 column 5
---- behavior::test_writer_write_with_overwrite ----
Unexpected (persistent) at write, context: { service: gdrive, path: 68b61cb3-9ec0-4c79-9694-83b56d38e9ea } => deserialize json, source: missing field `modifiedTime` at line 8 column 5
---- behavior::test_writer_abort ----
test panicked: assertion `left == right` failed
left: Unexpected
right: Unsupported
---- behavior::test_writer_abort_with_concurrent ----
test panicked: assertion `left == right` failed
left: Unexpected
right: Unsupported
|
|
hi @Xuanwo @erickguan thank you both for taking a look and noticing errors! i might not be able to help today (sorry!) but will follow up on the issue later if it has not been fixed yet. |
|
I will look over it firstly and ping you back for the PR. |
3 participants
Which issue does this PR close?
part of #5693
Rationale for this change
What changes are included in this PR?
Adds the
fieldsparameter which tells the gdrive API to include additional metadata in the response, and now returnsid,name,mimeType,size,modifiedTime,md5Checksum,version. Relevant metadata is picked from docs.Are there any user-facing changes?