Skip to content

Comments

chore(bindings/python): Add Justfile and format codebase#6677

Merged
Xuanwo merged 19 commits intoapache:mainfrom
chitralverma:py-justfile-fmt
Oct 17, 2025
Merged

chore(bindings/python): Add Justfile and format codebase#6677
Xuanwo merged 19 commits intoapache:mainfrom
chitralverma:py-justfile-fmt

Conversation

@chitralverma
Copy link
Contributor

@chitralverma chitralverma commented Oct 16, 2025 •
edited
Loading

Which issue does this PR close?

Parts from #6622

Rationale for this change

Partially Closes #6253

What changes are included in this PR?

  • Adds Justfile
  • Formats everything as per ruff rules (some rules are temporarily added and will be removed post stubs)
    • No functional change
  • Update Readme and Contributing guides as per the new Justfile
  • Update CI workflow to rely on justfile

Are there any user-facing changes?

No, just better dev experience and code formatting.
No breaking changes are introduced.

@chitralverma chitralverma changed the title Py justfile fmt feat(bindings/python): Add Justfile and format codebase Oct 16, 2025
Xuanwo
Xuanwo reviewed Oct 16, 2025
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this, but the change set is too complex to me.

@chitralverma
Copy link
Contributor Author

chitralverma commented Oct 16, 2025 •
edited
Loading

Thank you for working on this, but the change set is too complex to me.

most of the changes are a result of linting and formatting from ruff.

the tests and the benchmarks pass as usual.
No functional change is introduced.

@chitralverma chitralverma marked this pull request as ready for review October 16, 2025 16:06
Xuanwo
Xuanwo reviewed Oct 16, 2025
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this! I’d really like us to start with a simple, clean Justfile containing only the essential steps. I don’t want to maintain one cluttered with commands I never use.

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. releases-note/feat The PR implements a new feature or has a title that begins with "feat" labels Oct 16, 2025
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Oct 16, 2025
@chitralverma chitralverma requested a review from Xuanwo October 16, 2025 16:50
@chitralverma
Copy link
Contributor Author

chitralverma commented Oct 16, 2025 •
edited
Loading

@Xuanwo i've dropped some unnecessary changes (removed "RUF", # ruff-specific rules) from this PR in addition to your comments.
ready for your review, whenever you've time/

@chitralverma chitralverma changed the title feat(bindings/python): Add Justfile and format codebase chore(bindings/python): Add Justfile and format codebase Oct 16, 2025
Xuanwo
Xuanwo approved these changes Oct 17, 2025
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 17, 2025
@Xuanwo Xuanwo merged commit b6827c2 into apache:main Oct 17, 2025
63 checks passed
@chitralverma chitralverma deleted the py-justfile-fmt branch October 17, 2025 07:46
@chitralverma chitralverma mentioned this pull request Oct 31, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@messense messense Awaiting requested review from messense messense is a code owner

@Zheaoli Zheaoli Awaiting requested review from Zheaoli Zheaoli is a code owner

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer releases-note/feat The PR implements a new feature or has a title that begins with "feat" size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

new feature: Improve automatic stub generation for python bindings

2 participants

@chitralverma @Xuanwo