feat(buffer): add chunk iterator for Buffer#6672
Merged
Xuanwo merged 1 commit intoapache:mainfrom Oct 15, 2025
Merged
Conversation
dosubot
bot
added
size:L
TennyZhuang
force-pushed
the
feat-buffer-chunks
branch
from
9dcf998 to
5fe8af7
Compare
Xuanwo
approved these changes
Oct 15, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for working on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6520.
Rationale for this change
Splitting
Buffervalues into fixed-size chunks currently requires copying intoVec<u8>orBytes. Adding a chunk iterator exposes an ergonomic, zero-copy approach to splitting contiguous and non-contiguous buffers, matching the use cases raised in #6520.What changes are included in this PR?
BufferChunksplus aBuffer::chunkshelper that yield sub-buffers sharing the underlying storage.ExactSizeIterator,FusedIterator) with accurate size hints for predictable iteration.Are there any user-facing changes?
New optional API
Buffer::chunks; existing behavior is unchanged.