Conversation
Signed-off-by: Xuanwo <[email protected]>
dosubot
bot
added
size:XXL
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
dosubot
bot
added
size:XL
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
| def __init__( | ||
| self, | ||
| scheme: Literal["aliyun_drive"], | ||
| scheme: Literal["aliyun-drive"], |
There was a problem hiding this comment.
@Xuanwo aren't some changes required in dev/src/generate/python.j2 as well. otherwise these will be overwritten by just generate python
There was a problem hiding this comment.
You are right on this! Would you like to have a PR for this? Or I'll create one as follow up.
There was a problem hiding this comment.
let me take a shot at this in the next one.
| #[test] | ||
| fn from_uri_sets_repo_type_id_and_revision() { | ||
| let uri = OperatorUri::new( | ||
| "huggingface://model/opendal/sample/main/dataset", |
There was a problem hiding this comment.
Hi ! Just a heads up that HF uses hf://{owner}/{repo}/{path_in_repo}, it would be cool to follow this :)
And to summarize the spec, if there is a revision it should be hf://{owner}/{repo}@{revision}/{path_in_repo}
and for datasets and spaces it's respectively hf://datasets/{owner}/{repo}/{path_in_repo} and hf://spaces/{owner}/{repo}/{path_in_repo}
4 participants
Which issue does this PR close?
Part of #5445
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?