Conversation
Signed-off-by: tison <[email protected]>
dosubot
bot
added
size:M
bindings/ruby/Rakefile
Outdated
| desc "Copy the core directory for gem packaging" # Read more in `./.github/workflows/release-ruby.yml` | ||
| task :copy_core do | ||
| puts "Copy the core directory for packaging..." | ||
| FileUtils.cp_r('../../core', '.') |
There was a problem hiding this comment.
Perhaps add to .gitigonre and delete every time before copy. But let's first verify a happy path can work.
Signed-off-by: tison <[email protected]>
|
@erikguan could you please take a look? Anyway we should avoid simply adding a symbol link to Not quite sure if gem only include files in the same directory and we should do something different. For example, always copy |
Signed-off-by: tison <[email protected]>
|
I'll merge this patch first. And @erickguan can give another look for further improvement. |
| # 1. this crate won't be published, we always use the local version | ||
| # 2. we use the symbolink to allow released gem to find core's source files. | ||
| opendal = { version = ">=0", path = "./core", features = [ | ||
| opendal = { version = ">=0", path = "../../core", features = [ |
There was a problem hiding this comment.
The problem is that distributed gem can't look into the parent directory for security reasons.
@tisonkun do you have a way to resolve this based on dev/distributed environment?
| tags: | ||
| - 'v[0-9]+.[0-9]+.[0-9]+-rc.[0-9]+' # Triggers on version tags (v0.54.0, v0.54.0-rc.1, etc.) | ||
| # Triggers on version tags (v0.54.0, v0.54.0-rc.1, etc.) | ||
| - 'v[0-9]+.[0-9]+.[0-9]+' |
3 participants
cc @erickguan for verification