Skip to content

Comments

fix(bindings/ruby): publish ruby binding gem#6606

Merged
erickguan merged 10 commits intomainfrom
publish-ruby-binding
Oct 1, 2025
Merged

fix(bindings/ruby): publish ruby binding gem#6606
erickguan merged 10 commits intomainfrom
publish-ruby-binding

Conversation

@erickguan
Copy link
Member

@erickguan erickguan commented Sep 30, 2025 •
edited
Loading

Closes #5227

Final fix! I have pushed some releases. The last one is [0.1.5](https://rubygems.org/gems/opendal) with native gems.

Got an important feedback on release process:

  • lock workflows to only publish with release tag.
  • manual workflow can only publish rc version.

We are here at the beginning line:

image image

Review notes:

  • Multiple commits, better review commit by commit, and skip version bump commit.
  • Moved "layers" to a new Middleware namespace but trivial.
  • Many changes to the workflow but the gist is that using a native worker to build a native gem. And then push them together.

Future work:

  • If we want to sync the version number with core, add an issue for tracking. For now, the workflow:
    • if we have a newer version tag, builds a tag;
    • if we have the same version tag, do nothing.
  • Of course, better documentation.

@erickguan erickguan force-pushed the publish-ruby-binding branch 5 times, most recently from 46e56a2 to 1a5245a Compare September 30, 2025 19:54
@erickguan erickguan changed the title Publish ruby binding fix(bindings/ruby): publish ruby binding gem Sep 30, 2025
@erickguan erickguan force-pushed the publish-ruby-binding branch 2 times, most recently from d77f0da to ceb1037 Compare September 30, 2025 21:02
@erickguan erickguan marked this pull request as ready for review September 30, 2025 21:02
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. releases-note/fix The PR fixes a bug or has a title that begins with "fix" labels Sep 30, 2025
@erickguan erickguan force-pushed the publish-ruby-binding branch from 558fbbb to c5f1e5c Compare October 1, 2025 07:52
@Xuanwo
Copy link
Member

Xuanwo commented Oct 1, 2025

Oh, sorry for not making it clear. As an ASF project, we cannot release without a vote. For development and testing purpose, we can uploads the rc releases.

@Xuanwo
Copy link
Member

Xuanwo commented Oct 1, 2025

If we want to sync the version number with core, add an issue for tracking. For now, the workflow:
if we have a newer version tag, builds a tag;
if we have the same version tag, do nothing.

What's the meaning of this, won't we release together with core?

@Xuanwo
Copy link
Member

Xuanwo commented Oct 1, 2025

By the way, all artifacts must be controlled by OpenDAL PMC. Could you invite me and @PsiACE as co-owners of this package?

My id should be xuanwo

@erickguan erickguan force-pushed the publish-ruby-binding branch from c5f1e5c to e90b16f Compare October 1, 2025 09:16
@erickguan
Copy link
Member Author

erickguan commented Oct 1, 2025 •
edited
Loading

If we want to sync the version number with core, add an issue for tracking. For now, the workflow:
if we have a newer version tag, builds a tag;
if we have the same version tag, do nothing.

What's the meaning of this, won't we release together with core?

Discussed briefly offline.

@erickguan erickguan force-pushed the publish-ruby-binding branch from e90b16f to bc86cac Compare October 1, 2025 10:38
@erickguan erickguan marked this pull request as draft October 1, 2025 10:46
@erickguan erickguan force-pushed the publish-ruby-binding branch 2 times, most recently from 683bc66 to cbd53cd Compare October 1, 2025 11:34
@erickguan erickguan marked this pull request as ready for review October 1, 2025 11:34
@erickguan
Fix release workflows
80a1a19 
Fixes file paths to include core files
Fixes complilations
Fixes artifact downloads
Lock release tags
@erickguan
Fix metadata's inspect
82ffdf4
@erickguan
Move middlewares to OpenDal::Middlware
b783e1b
@erickguan
Fix tests in CI
ca1ffd7
@erickguan erickguan force-pushed the publish-ruby-binding branch from cbd53cd to 7b5eff7 Compare October 1, 2025 11:58
@PsiACE
Copy link
Member

PsiACE commented Oct 1, 2025

thanks @erickguan and @Xuanwo , my username is PsiACE

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 1, 2025
@erickguan erickguan merged commit 74ebf54 into main Oct 1, 2025
42 checks passed
@erickguan erickguan deleted the publish-ruby-binding branch October 1, 2025 18:18
@erickguan
Copy link
Member Author

erickguan commented Oct 1, 2025

Thanks for the review!

tisonkun
tisonkun reviewed Oct 7, 2025
View reviewed changes
.github/workflows/release_ruby.yml
push:
tags:
- 'v[0-9]+.[0-9]+.[0-9]+*' # Triggers on version tags (v0.54.0, v0.54.0-rc.1, etc.)
- 'v[0-9]+.[0-9]+.[0-9]+-rc.[0-9]+' # Triggers on version tags (v0.54.0, v0.54.0-rc.1, etc.)
Copy link
Member

@tisonkun tisonkun Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would not match v0.54.0.

tisonkun
tisonkun reviewed Oct 7, 2025
View reviewed changes
bindings/ruby/core
Copy link
Member

@tisonkun tisonkun Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This softlink would cause a build warning:

warning: skipping duplicate package `opendal v0.54.1 (https://github.com/apache/opendal?rev=928db5a2#928db5a2)`:
  /home/.cargo/git/checkouts/opendal-a12b7d85ff19463e/928db5a/bindings/ruby/core/Cargo.toml
in favor of /home/.cargo/git/checkouts/opendal-a12b7d85ff19463e/928db5a/core/Cargo.toml

@tisonkun
Copy link
Member

tisonkun commented Oct 7, 2025 •
edited
Loading

Both follow up at #6627

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tisonkun tisonkun tisonkun left review comments

@PsiACE PsiACE PsiACE approved these changes

@Xuanwo Xuanwo Awaiting requested review from Xuanwo Xuanwo is a code owner

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer releases-note/fix The PR fixes a bug or has a title that begins with "fix" size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

new feature: Basic Ruby binding

4 participants

@erickguan @Xuanwo @PsiACE @tisonkun