feat(services/s3): add support for HTTP 429 TooManyRequests for S3-compatible services#6589
Merged
Xuanwo merged 1 commit intoapache:mainfrom Sep 23, 2025
Merged
Conversation
dosubot
bot
added
size:XS
Xuanwo
approved these changes
Sep 23, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you for working on this!
Member
|
Clippy is failed, we can address them in an extra PR. |
sylvestre
added a commit
to sylvestre/sccache
that referenced
this pull request
Jan 19, 2026
sylvestre
added a commit
to sylvestre/sccache
that referenced
this pull request
Jan 19, 2026
sylvestre
added a commit
to mozilla/sccache
that referenced
this pull request
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6588
Rationale for this change
OpenDAL's S3 service currently only handles AWS S3's rate limiting pattern (HTTP 503 with "SlowDown" error code). Many S3-compatible services like Oracle Cloud Infrastructure Object Storage, Scaleway, and others return HTTP 429 with "TooManyRequests" error codes .
When these services return HTTP 429, OpenDAL classifies them as non-retryable
ErrorKind::Unexpectederrors, causing applications to fail permanently instead of implementing proper retry logic with exponential backoff. This breaks rate limiting functionality for users of S3-compatible services.What changes are included in this PR?
ErrorKind::RateLimitedin theparse_error()functionErrorKind::RateLimitedin theparse_s3_error_code()functiontrue) to enable proper retry behavior