Skip to content

Comments

feat(services/opfs): Add create_dir support for OPFS#6542

Merged
Xuanwo merged 1 commit intoapache:mainfrom
crwen:feat/opfs-create-dir
Sep 1, 2025
Merged

feat(services/opfs): Add create_dir support for OPFS#6542
Xuanwo merged 1 commit intoapache:mainfrom
crwen:feat/opfs-create-dir

Conversation

@crwen
Copy link
Contributor

@crwen crwen commented Aug 30, 2025

Which issue does this PR close?

Related to #. #5799

Rationale for this change

What changes are included in this PR?

  • Implement create_dir for OpfsBackend
  • Update CI for building OPFS service

I don't implement other methods because everything in wasm_bindgen is !Send and !Sync and I'm not sure if you can accept changing Send and Sync requirements of traits like List and Write to MaybeSend and MaybeSync.

Are there any user-facing changes?

@crwen crwen requested a review from Xuanwo as a code owner August 30, 2025 13:44
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. releases-note/feat The PR implements a new feature or has a title that begins with "feat" labels Aug 30, 2025
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @crwen for working on this!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 1, 2025
@Xuanwo Xuanwo merged commit 6e4e202 into apache:main Sep 1, 2025
336 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/feat The PR implements a new feature or has a title that begins with "feat" size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants