Skip to content

Comments

feat(bindings/ruby): support file open options#6538

Merged
Xuanwo merged 6 commits intomainfrom
ruby-binding-io
Sep 1, 2025
Merged

feat(bindings/ruby): support file open options#6538
Xuanwo merged 6 commits intomainfrom
ruby-binding-io

Conversation

@erickguan
Copy link
Member

@erickguan erickguan commented Aug 29, 2025

Which issue does this PR close?

Part of #5227

Better to review commit by commit.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@erickguan erickguan self-assigned this Aug 29, 2025
@erickguan erickguan requested a review from PsiACE as a code owner August 29, 2025 20:56
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. releases-note/feat The PR implements a new feature or has a title that begins with "feat" labels Aug 29, 2025
@erickguan erickguan changed the title Support file open options for Ruby binding IO feat(bindings/ruby): support file open options Aug 29, 2025
@erickguan
Copy link
Member Author

Inviting @yihong0618 for review. Maybe you are interested in Ruby too?

@yihong0618
Copy link
Contributor

seems its a break change with name openDAL -> openDal
I remember if we add break change we need to info the users

@erickguan
Copy link
Member Author

@yihong0618 Yes, you are right. The current status of Ruby binding is yet to publish - the idea is to make the first publish with a minimal set of features.

This is the last PR including these features.

Copy link
Contributor

@yihong0618 yihong0618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xuanwo Xuanwo merged commit 7783d01 into main Sep 1, 2025
37 checks passed
@Xuanwo Xuanwo deleted the ruby-binding-io branch September 1, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat" size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants