Skip to content

Comments

fix(bindings/cpp): correct cxx_async namespace attribute#6514

Merged
Xuanwo merged 5 commits intoapache:mainfrom
kingsword09:fix-bindings-cpp-cxx-async
Aug 19, 2025
Merged

fix(bindings/cpp): correct cxx_async namespace attribute#6514
Xuanwo merged 5 commits intoapache:mainfrom
kingsword09:fix-bindings-cpp-cxx-async

Conversation

@kingsword09
Copy link
Contributor

Which issue does this PR close?

fix https://github.com/apache/opendal/actions/runs/17062459130/job/48371928070

Rationale for this change

  • fix cxx_async namespace attribute
  • make clippy happy
  • upgrade cxx-async version

What changes are included in this PR?

Are there any user-facing changes?

@kingsword09 kingsword09 requested a review from Xuanwo as a code owner August 19, 2025 09:32
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. releases-note/fix The PR fixes a bug or has a title that begins with "fix" labels Aug 19, 2025
@kingsword09 kingsword09 marked this pull request as draft August 19, 2025 09:37
@kingsword09
Copy link
Contributor Author

kingsword09 commented Aug 19, 2025

Rename the namespace from ‎opendal::ffi::async to ‎opendal::ffi::async_op because ‎async is a reserved keyword.

image

@kingsword09 kingsword09 marked this pull request as ready for review August 19, 2025 15:23
@kingsword09
Copy link
Contributor Author

cc @Xuanwo

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Aug 19, 2025
@devillove084
Copy link
Contributor

I'm also working on resolving this issue, and I'm glad to see someone has already submitted a PR ahead of me.

@Xuanwo
Copy link
Member

Xuanwo commented Aug 19, 2025

Thank you for working on this!

@Xuanwo Xuanwo merged commit c4e8b00 into apache:main Aug 19, 2025
106 of 107 checks passed
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 19, 2025
@kingsword09 kingsword09 deleted the fix-bindings-cpp-cxx-async branch August 19, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/fix The PR fixes a bug or has a title that begins with "fix" size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants