Skip to content

Comments

fix(services/moka): prevent the weigher from being overwritten#6498

Merged
Xuanwo merged 1 commit intomainfrom
remove-moka-weigher
Aug 9, 2025
Merged

fix(services/moka): prevent the weigher from being overwritten#6498
Xuanwo merged 1 commit intomainfrom
remove-moka-weigher

Conversation

@koushiro
Copy link
Member

@koushiro koushiro commented Aug 9, 2025

Which issue does this PR close?

Closes #.

Rationale for this change

User-defined moka weigher will be overwritten

What changes are included in this PR?

Remove the existing weigher

Are there any user-facing changes?

@koushiro koushiro requested a review from Xuanwo as a code owner August 9, 2025 12:27
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. releases-note/fix The PR fixes a bug or has a title that begins with "fix" labels Aug 9, 2025
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 9, 2025
@Xuanwo Xuanwo merged commit 7ca5736 into main Aug 9, 2025
88 checks passed
@Xuanwo Xuanwo deleted the remove-moka-weigher branch August 9, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/fix The PR fixes a bug or has a title that begins with "fix" size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants