Skip to content

Comments

ci: update workflow nodejs version and remove corepack#6495

Merged
Xuanwo merged 1 commit intoapache:mainfrom
kingsword09:update-nodejs-docs-workflow
Aug 9, 2025
Merged

ci: update workflow nodejs version and remove corepack#6495
Xuanwo merged 1 commit intoapache:mainfrom
kingsword09:update-nodejs-docs-workflow

Conversation

@kingsword09
Copy link
Contributor

@kingsword09 kingsword09 commented Aug 8, 2025

Which issue does this PR close?

Closes #.

Rationale for this change

Node.js 18 has reached EOL. This PR updates all relevant CI workflows to use Node.js 20 for consistency across the project.

What changes are included in this PR?

Are there any user-facing changes?

@kingsword09 kingsword09 requested a review from Xuanwo as a code owner August 8, 2025 15:13
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. releases-note/ci The PR modifies CI-related content or has a title that begins with "ci" labels Aug 8, 2025
Xuanwo
Xuanwo approved these changes Aug 9, 2025
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 9, 2025
@Xuanwo
Copy link
Member

Xuanwo commented Aug 9, 2025

So corepack not a thing after Nodejs 18?

@Xuanwo Xuanwo merged commit c6f9f1f into apache:main Aug 9, 2025
63 checks passed
@kingsword09
Copy link
Contributor Author

kingsword09 commented Aug 9, 2025 •
edited
Loading

So corepack not a thing after Nodejs 18?

Since we are using pnpm/action-setup@v4 and have specified the pnpm version, then don't need to use the corepack.

npm i -g --force corepack && corepack enable This is to enable the pnpm package management tool, but we've already included the pnpm package management tool in our environment using pnpm/action-setup, so it's repetitive behavior.

@kingsword09 kingsword09 deleted the update-nodejs-docs-workflow branch August 9, 2025 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer releases-note/ci The PR modifies CI-related content or has a title that begins with "ci" size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kingsword09 @Xuanwo