Skip to content

Comments

feat: Add if-not-exists support for copy with azblob as example#6447

Merged
Xuanwo merged 6 commits intomainfrom
feat/copy-if-not-exists
Jul 29, 2025
Merged

feat: Add if-not-exists support for copy with azblob as example#6447
Xuanwo merged 6 commits intomainfrom
feat/copy-if-not-exists

Conversation

@Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jul 29, 2025

Which issue does this PR close?

Closes #5024

Rationale for this change

Add if_not_exists support for copy operations.

What changes are included in this PR?

Add if_not_exists in OpCopy.

Are there any user-facing changes?

New API: copy_with(path).if_not_exists(true).

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. releases-note/feat The PR implements a new feature or has a title that begins with "feat" labels Jul 29, 2025
@Xuanwo
Copy link
Member Author

Xuanwo commented Jul 29, 2025

Ooops, aws seems not support this by now. Will take a deeper look.

Xuanwo added 2 commits July 29, 2025 19:20
@Xuanwo
Try new API
1861838 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Format code
e10f6ed 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Copy link
Member Author

Xuanwo commented Jul 29, 2025 •
edited
Loading 

ERROR opendal::services: service=s3 name=*** from=6aa63316-c2c8-4fe8-9659-056688f5d83e to=97d73661-18ef-4d3f-981a-ca69bbcfdb53: copy failed Unexpected (permanent) at copy => S3Error { code: "NotImplemented", message: "A header you provided implies functionality that is not implemented", resource: "", request_id: "DK3H4WE9CRZK14H0" }

I thought AWS has supported this...

@Xuanwo Xuanwo changed the title feat: Add if-not-exists support for copy feat: Add if-not-exists support for copy with azblob as example Jul 29, 2025
@Xuanwo
Make clippy happy
38181cf 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo merged commit 50d1a3c into main Jul 29, 2025
361 of 362 checks passed
@Xuanwo Xuanwo deleted the feat/copy-if-not-exists branch July 29, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yihong0618 yihong0618 yihong0618 approved these changes

Assignees

No one assigned

Labels

releases-note/feat The PR implements a new feature or has a title that begins with "feat" size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

new feature: Add 'overwrite' Attribute to OpCopy and OpWrite

2 participants

@Xuanwo @yihong0618