Skip to content

Comments

feat(bindings/cpp): remove Boost dependency#6376

Merged
Xuanwo merged 1 commit intoapache:mainfrom
JackDrogon:feature/cpp_remove_boost
Jul 11, 2025
Merged

feat(bindings/cpp): remove Boost dependency#6376
Xuanwo merged 1 commit intoapache:mainfrom
JackDrogon:feature/cpp_remove_boost

Conversation

@JackDrogon
Copy link
Contributor

Rationale for this change

reduce cpp binding dep

What changes are included in this PR?

  • Remove Boost dependency from CMake configuration and documentation
  • Replace Boost.DateTime with std::chrono for timestamp handling
  • Replace Boost.IOStreams with custom std::istream implementation for ReaderStream
  • Update all header includes and modernize C++ usage

- Remove Boost dependency from CMake configuration and documentation
- Replace Boost.DateTime with std::chrono for timestamp handling
- Replace Boost.IOStreams with custom std::istream implementation for ReaderStream
- Update all header includes and modernize C++ usage

Signed-off-by: Jack Drogon <[email protected]>
@JackDrogon JackDrogon requested a review from Xuanwo as a code owner July 8, 2025 10:52
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. releases-note/feat The PR implements a new feature or has a title that begins with "feat" labels Jul 8, 2025
@Xuanwo Xuanwo requested review from silver-ymz and xyjixyjixyji July 8, 2025 11:47
@Xuanwo
Copy link
Member

Xuanwo commented Jul 8, 2025

Mostly LGTM, inviting @silver-ymz and @xyjixyjixyji for another look.

@JackDrogon
Copy link
Contributor Author

@Xuanwo @silver-ymz @xyjixyjixyji please help me review the pr

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me for not depending on boost.

@Xuanwo Xuanwo merged commit d7580b4 into apache:main Jul 11, 2025
32 checks passed
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer releases-note/feat The PR implements a new feature or has a title that begins with "feat" size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants