refactor: Migrate mini_moka service to implement Access directly#6316
Merged
refactor: Migrate mini_moka service to implement Access directly#6316
Conversation
dosubot
bot
added
size:L
meteorgan
commented
Jun 19, 2025
| } | ||
|
|
||
| let offset = range.offset() as usize; | ||
| if offset >= value.content.len() { |
Contributor
Author
There was a problem hiding this comment.
It appears we're missing relevant tests, which could potentially cause a panic.
Xuanwo
approved these changes
Jun 20, 2025
Member
Xuanwo
left a comment
Xuanwo
left a comment
There was a problem hiding this comment.
Thank you @meteorgan for working on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #5739.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?