fix(bindings/python): Fix Writer doesn't throw correct error code#6315
Merged
fix(bindings/python): Fix Writer doesn't throw correct error code#6315
Conversation
Signed-off-by: Xuanwo <[email protected]>
dosubot
bot
added
size:S
messense
approved these changes
Jun 19, 2025
yihong0618
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6235
Rationale for this change
python bindings users
FuturesWriterdirectly which returns rust IO error. This can lead to we return different exceptions compared towrite.What changes are included in this PR?
This PR fixed this by downcast them to the correct error.
Are there any user-facing changes?
No.