refactor!: Remove stat_has_xxx and list_has_xxx#6313
Merged
Conversation
Signed-off-by: Xuanwo <[email protected]>
dosubot
bot
added
the
size:L
dosubot
bot
added
the
releases-note/refactor
yihong0618
approved these changes
Jun 18, 2025
Contributor
|
@Xuanwo @yihong0618 GreptimeDB used Since it’s been removed, is there a replacement API? Looks like it's always true, so maybe I can just remove this checking. Thank you. |
Member
Author
Sorry this change broke your use case. Could you please open a new issue? I believe we can come up with a new design to address it. |
Contributor
Sure! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
As suggested in #5557 (comment)
Rationale for this change
Make code more readable and maintainable.
What changes are included in this PR?
Remove all stat_has_xxx and list_has_xxx fields.
Are there any user-facing changes?
Capability removed.